Jump to content

Recommended Posts

1 hour ago, Switzeran said:

I have added the Scribunto extension, which is what Wikipedia uses for LUA.  There's one small step related to SELinux I haven't done yet, but if you have some means of testing to see if it works without that step, please do feel free to give it a shot.

A simple hello world module is already working!

Share this post


Link to post
Share on other sites
Posted (edited)

I removed my tweak to try and fix the cite issue as I saw that going back to the reference list ended up having it be broken through odd reformatting. If anyone has any ideas for how to provide a top/margin to the click back to the header without then messing up the return, feel free to propose it!

 

ETA: I suspect the solution may be difficult, because testing on Wikipedia's responsive skin (Timeless) they themselves have the cite back anchors place it under the header. So... I will stop putting time into it myself, because it's above my expertise level.

Edited by Switzeran

Share this post


Link to post
Share on other sites
Posted (edited)
8 hours ago, Switzeran said:

I removed my tweak to try and fix the cite issue as I saw that going back to the reference list ended up having it be broken through odd reformatting. If anyone has any ideas for how to provide a top/margin to the click back to the header without then messing up the return, feel free to propose it!

I know little and less of CSS, but hopefully these might help: https://stackoverflow.com/questions/10732690/ https://stackoverflow.com/questions/4086107/

Edited by zionius

Share this post


Link to post
Share on other sites
4 hours ago, zionius said:

I know little and less of CSS, but hopefully these might help: https://stackoverflow.com/questions/10732690/ https://stackoverflow.com/questions/4086107/

That and some other pages are where I got my ideas for how to try and fix the issue. Unfortunately, those were leading to the formatting issues you cited. I'm not familiar enough with CSS to figure out how to tweak things to make it play nice. I may take another crack at it, or perhaps ask around.

Share this post


Link to post
Share on other sites

Thanks for adding Scribunto. I've copied some modules from Wikipedia and they seem to work fine. There will need to be an update to the css however, as currently navboxes and infoboxes do not look as good as they could. I've added some personal css, when I think it is ready I will ask for it to be moved to the main common.css. If anyone is curious, you can copy the content of https://awoiaf.westeros.org/index.php/User:Abjiklam/common.css to your own personal css and have a look at https://awoiaf.westeros.org/index.php/Template:Infobox_character/test.

One thing that would be very useful is case-insensitive search. This would make browsing much easier.

Share this post


Link to post
Share on other sites

On mobile, the navbar takes too much space because the title and menu icon don't fit on the same line.

Share this post


Link to post
Share on other sites
Posted (edited)

Actually, I think it's an issue with a div under the navbar. When I remove that div in Chrome's inspector, the menu pops in where it should. I've an idea as to how to fix it.

 

ETA: Think I fixed it.

Edited by Switzeran

Share this post


Link to post
Share on other sites

I think I have a working css for the infobox. Could the content of https://awoiaf.westeros.org/index.php/User:Abjiklam/infobox.css replace whichever css is being used right now? I only made sure the padding between cells came back, and I made the infobox responsive to screen size, so that when the navbar collapses, the infobox stops floating and instead becomes a centered element with the main text coming after.

Share this post


Link to post
Share on other sites
2 hours ago, Switzeran said:

Actually, I think it's an issue with a div under the navbar. When I remove that div in Chrome's inspector, the menu pops in where it should. I've an idea as to how to fix it.

 

ETA: Think I fixed it.

The problem is still not fixed on my phone, and the title really does take too much space to fit on the same line. See: https://imgur.com/a/ClTyTPW

Share this post


Link to post
Share on other sites
Posted (edited)
42 minutes ago, Abjiklam said:

The problem is still not fixed on my phone, and the title really does take too much space to fit on the same line. See: https://imgur.com/a/ClTyTPW

What device is that? On the phone it's okay for me. That said, it's a fairly large phone, so I can shrink down the font further. I've changed it now to 20px for viewports under 992px wide.

 

BTW, liked the look of the new infoboxes. Thanks for working on that. :) If they can handle responsive image resizing at all, that would be even better as it would play nicer on mobile.

Edited by Switzeran

Share this post


Link to post
Share on other sites
Posted (edited)
1 hour ago, Switzeran said:

What device is that? On the phone it's okay for me. That said, it's a fairly large phone, so I can shrink down the font further. I've changed it now to 20px for viewports under 992px wide.

 

BTW, liked the look of the new infoboxes. Thanks for working on that. :) If they can handle responsive image resizing at all, that would be even better as it would play nicer on mobile.

Looks good now! The phone is a OnePlus One.

I've added the styling that make the infobox images responsive.

Edited by Abjiklam

Share this post


Link to post
Share on other sites
On 7/4/2018 at 4:20 PM, Switzeran said:

I have removed the right bar banner from User talk pages, which should address this issue.

Will this work on all other pages, too?

 

Looking at the new layout on desktop, I wonder if it is possible to use the left side of the page a bit more by making the space of the wiki text wider. As you can see on the screenshot, there's quite some space left on the left side of the page which is currently not occupied by text.

Previously, the advertising banner on the right side was split between the left and right side of the page, with the wiki text filling up all the space in between. Now that he advertising banners are combined to form one bigger banner on the right side, but the left side is left empty, the total width of the wiki text is smaller. Would it be possible to use the current empty space to make more room for the text?

Share this post


Link to post
Share on other sites

Additional remarks:

- The subheadings under "Recent Events", which have the wiki-coding for italic text, are still not displayed in italic. Any ideas on this?

- The size of the text of quote template is quite large. A bit too large, in my opinion. Is this something that needs to be changed in the common.css? Or simply in the template itself?

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×